Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

14294 - Fixes 'back' functionality after switching a store view. #15961

Conversation

Mobecls
Copy link
Contributor

@Mobecls Mobecls commented Jun 8, 2018

Description

Modifies switcher-option's link Magento/Store/view/frontend/templates/switch/languages.phtml template.

Fixed Issues (if relevant)

  1. Since MagentoCE2.1.11, after swithing store view, ___store=xx is added to url. Breaks 'back' functionality. #14294: Since MagentoCE2.1.11, after swithing store view, ___store=xx is added to url. Breaks 'back' functionality.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jun 8, 2018

CLA assistant check
All committers have signed the CLA.

@Mobecls
Copy link
Contributor Author

Mobecls commented Jun 15, 2018

@VladimirZaets, could you, please, help what exactly should I fix to pass the tests https://travis-ci.org/magento/magento2/jobs/389750567. Is that my fault the test shows these errors "Warning: PhantomJS timed out, possibly due to an unfinished async spec.� Use --force to continue." and "Aborted due to warnings."?

@magento-engcom-team
Copy link
Contributor

Hi @Mobecls. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@Mobecls
Copy link
Contributor Author

Mobecls commented Nov 12, 2018

cool, thanks

@ihor-sviziev ihor-sviziev mentioned this pull request Aug 18, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants