Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change "My Dashboard" to "My Account", fixes #16007 #16009

Merged
merged 2 commits into from Jul 3, 2018
Merged

fix: change "My Dashboard" to "My Account", fixes #16007 #16009

merged 2 commits into from Jul 3, 2018

Conversation

DanielRuf
Copy link
Contributor

Description

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title
  2. ...

Manual testing scenarios

  1. ...
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@misha-kotov
Copy link

Hi @DanielRuf, do your changes affect both of these labels? Anywhere else?
image

@DanielRuf
Copy link
Contributor Author

So far these should at least affect the makred ones + title.

@DanielRuf
Copy link
Contributor Author

Should we also change "Account Dashboard" to "My Account"?

@VladimirZaets
Copy link
Contributor

@DanielRuf I think, yes
@misha-kotov can you please clarify all places where we should replace?
Thanks

@misha-kotov
Copy link

@DanielRuf the marked labels above + title sounds right to me. Are you saying there another "account dashboard" somewhere?

@DanielRuf
Copy link
Contributor Author

@DanielRuf the marked labels above + title sounds right to me. Are you saying there another "account dashboard" somewhere?

I did not change the "Account Dashboard" on the left but should also change this.

@VladimirZaets
Copy link
Contributor

Hi @DanielRuf, can you please also change "Account Dashboard" label. Thanks

@VladimirZaets
Copy link
Contributor

Hi @DanielRuf, I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for collaboration

@DanielRuf DanielRuf reopened this Jul 2, 2018
@DanielRuf
Copy link
Contributor Author

Please reopen and update if you wish to continue.

Done.

@VladimirZaets
Copy link
Contributor

Hi @DanielRuf , thanks for the update.

@magento-engcom-team
Copy link
Contributor

Hi @DanielRuf. Thank you for your contribution.
We will aim to release these changes as part of 2.2.6.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@DanielRuf DanielRuf deleted the fix/change-my-dashboard-to-my-account branch July 4, 2018 06:59
@DanielRuf
Copy link
Contributor Author

Backport failed on 2.1. Do we still need it for 2.1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants