Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the favicon file to the newer Magento logo #16061

Merged
merged 1 commit into from
Jun 19, 2018
Merged

Change the favicon file to the newer Magento logo #16061

merged 1 commit into from
Jun 19, 2018

Conversation

DMMundle
Copy link
Contributor

Description

  • remove white background
  • update orange to official color

Manual testing scenarios

  1. Validate the favicon on the setup and admin match the magento.com favicon

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@DMMundle
Change the favicon file to the newer Magento logo
5124ad9 
 - remove white background,
 - update orange to official colour
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jun 12, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@miguelbalparda miguelbalparda self-assigned this Jun 12, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Jun 16, 2018
@magento-engcom-team
Copy link
Contributor

Hi @miguelbalparda, thank you for the review.
ENGCOM-2015 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@DMMundle thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team magento-engcom-team merged commit 5124ad9 into magento:2.3-develop Jun 19, 2018
magento-engcom-team pushed a commit that referenced this pull request Jun 19, 2018
ENGCOM-2015: Change the favicon file to the newer Magento logo #16061
6ad774d
@magento-engcom-team
Copy link
Contributor

Hi @DMMundle. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

@DMMundle
Copy link
Contributor Author

Thanks to @dmanners, @soumya-ashok, @miguelbalparda, @RebeccaBrocton, and anyone else involved on the @magento-engcom-team for helping me with this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelbalparda miguelbalparda miguelbalparda approved these changes

Assignees

@miguelbalparda miguelbalparda

Labels
Component: Theme Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@DMMundle @magento-cicd2 @magento-engcom-team @miguelbalparda