Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Date Range Filter Error In Admin #16119

Closed
wants to merge 1 commit into from
Closed

Fix Date Range Filter Error In Admin #16119

wants to merge 1 commit into from

Conversation

yuriyDne
Copy link

Fix for Issue 13428: Date range filter in admin ui grid displaying "Invalid date" after reload

Description

#13428
Date range filter in admin ui grid displaying "Invalid date" after reload

Fixed Issues (if relevant)

  1. Date range filter in admin ui grid displaying "Invalid date" after reload #13428:Date range filter in admin ui grid displaying "Invalid date" after reload
  2. ...

Manual testing scenarios

  1. Create a new sales order, if there are no sales orders already
  2. Go to the orders admin grid
  3. Filter the grid by "Order Date"
  4. After the grid has been filtered by the date range, reload/refresh the page

Actual result

  1. Date range is properly displayed in the "Active filters" area

Previous result

  1. Date range is displayed improperly, including an "Invalid date" message

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jun 14, 2018
@magento-engcom-team
Copy link
Contributor

Hi @yuriyDne. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on Pull Request changes
  • @magento-engcom-team give me new test instance - deploy NEW test instance based on Pull Request changes
  • @magento-engcom-team give me {$VERSION} instance - deploy Vanilla Magento instance for Issue or Pull Request

For more details, please, review the Magento Contributor Assistant documentation

@yuriyDne
Copy link
Author

This bug has already fixed in 2.2-develop branch

@yuriyDne yuriyDne closed this Jun 15, 2018
@yuriyDne yuriyDne deleted the Fix-Date-Range-Filter-Error-In-Admin branch June 15, 2018 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Component: Ui Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants