Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare module namespace before template path name(Magento_Sales::order/info.phtml). #16206

Merged
merged 1 commit into from
Jun 21, 2018

Conversation

ronak2ram
Copy link
Member

@ronak2ram ronak2ram commented Jun 18, 2018

Description

When we override block info(Magento\Sales\Block\Order\Info) to my custom module.
It throws an error and finding order/info.phtml in my custom module.
I tried to extend Block Magento\Sales\Block\Order\Info from my custom module.

1 exception(s):
Exception #0 (Magento\Framework\Exception\ValidatorException): Invalid template file: 'order/info.phtml' in module: 'Vendor_Module' block's name: 'sales.order.info'

Fixed Issues (if relevant)

  1. Declare module namespace before template path name.

Manual testing scenarios

  1. I override info block
<preference for="Magento\Sales\Block\Order\Info"
				type="Vendor\Module\Block\Order\Info" />

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jun 18, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @ronak2ram. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on Pull Request changes
  • @magento-engcom-team give me new test instance - deploy NEW test instance based on Pull Request changes
  • @magento-engcom-team give me {$VERSION} instance - deploy Vanilla Magento instance for Issue or Pull Request

For more details, please, review the Magento Contributor Assistant documentation

@ronak2ram ronak2ram changed the title Update Info.php Declare module namespace before template path name(Magento_Sales::order/info.phtml). Jun 18, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.6 milestone Jun 18, 2018
@magento-engcom-team
Copy link
Contributor

@ronak2ram thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team magento-engcom-team merged commit e687fed into magento:2.2-develop Jun 21, 2018
magento-engcom-team pushed a commit that referenced this pull request Jun 21, 2018
@magento-engcom-team
Copy link
Contributor

Hi @ronak2ram. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.6 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants