Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport 2.3] Trim email address in customer account create and login form #16293

Merged

Conversation

dankhrapiyush
Copy link
Contributor

Original Pull Request

#16192

Related to issue: #6058

Description

Trim email address by remove leading or trailing space on following forms.

Fixed Issues (if relevant)

  1. IE11 user login email validation fails if field has leading or trailing space #6058: IE11 user login email validation fails if field has leading or trailing space

Manual testing scenarios

  1. Open customer account login page in Firefox or IE browser.
  2. Try to add space before entering an email address in the Email field.
  3. Copy " johndoe@domain.com " and paste in the Email field. It will automatically remove leading or trailing space.
  4. Check same on customer account create page
  5. Check same on customer authentication popup. To check this, set Store > Configuration > Sales > Checkout > Checkout Options > Allow Guest Checkout to No. Add product to cart and click on Proceed to Checkout button in the cart page or top mini cart.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @dankhrapiyush. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on Pull Request changes
  • @magento-engcom-team give me new test instance - deploy NEW test instance based on Pull Request changes
  • @magento-engcom-team give me {$VERSION} instance - deploy Vanilla Magento instance for Issue or Pull Request

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @dankhrapiyush. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants