Skip to content

Fixed Responsive Design, Footers bottom of screen on mobile devices #16323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Fixed Responsive Design, Footers bottom of screen on mobile devices #16323

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ac923e2
Fixes responsive footer
chirag-wagento Jun 22, 2018
de6afe6
fix hight issue on desktop view.
chirag-wagento Jun 22, 2018
3d72fab
Merge remote-tracking branch 'origin/2.2-develop' into fix-footer-res…
chirag-wagento Jun 25, 2018
eaa4b6b
add display inline grid for footer responsive
chirag-wagento Jun 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 27 additions & 6 deletions app/design/frontend/Magento/luma/Magento_Theme/web/css/source/_module.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,32 @@
// _____________________________________________

.media-width(@extremum, @break) when (@extremum = 'max') and (@break = @screen__m) {

html,
body {
height: 100%; // Stretch screen area for sticky footer
display: inline-grid;
}

header,
main,
footer {
flex-shrink: 0;
}

.page-wrapper {
.lib-vendor-prefix-display(flex);
.lib-vendor-prefix-flex-direction(column);
align-items: stretch;
-webkit-align-items: stretch;
min-height: 100%; // Stretch content area for sticky footer
.page-main {
flex-grow: 1;
-webkit-flex-grow: 1;
}
}


.customer-name,
.customer-welcome + .authorization-link {
display: none;
Expand Down Expand Up @@ -418,12 +444,6 @@
}
}
}
.page-footer,
.copyright {
bottom: 0;
position: absolute;
width: 100%;
}
}

.media-width(@extremum, @break) when (@extremum = 'max') and (@break = @screen__s) {
Expand All @@ -441,6 +461,7 @@
html,
body {
height: 100%; // Stretch screen area for sticky footer
display: inline-grid;
}

body {
Expand Down