Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] Fixes updating wishlist item if an item object is passed instead its id. #16391

Conversation

eduard13
Copy link
Contributor

@eduard13 eduard13 commented Jun 25, 2018

Description

Original PR #16372

This PR fixes removing the wishlist item from wishlist while updating it, if instead of id it is sent \Magento\Wishlist\Model\Item object.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Component: Wishlist labels Jun 25, 2018
@magento-engcom-team
Copy link
Contributor

Hi @eduard13. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@eduard13 eduard13 changed the title Fixes updating wishlist item if an item object is passed instead its id. [Forwardport] Fixes updating wishlist item if an item object is passed instead its id. Jun 25, 2018
@eduard13 eduard13 requested a review from rogyar June 25, 2018 18:38
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Jun 26, 2018
@orlangur orlangur self-assigned this Jun 26, 2018
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-2130 has been created to process this Pull Request

@sidolov
Copy link
Contributor

sidolov commented Jul 4, 2018

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @sidolov. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, here is your new Magento instance.
Admin access: https://pr-16391.engcom.dev.magento.com/admin
Login: admin Password: 123123q
Please make sure you are PR author or assignee to access the instance.

@magento-engcom-team magento-engcom-team merged commit 3a64d3c into magento:2.3-develop Jul 4, 2018
magento-engcom-team pushed a commit that referenced this pull request Jul 4, 2018
magento-engcom-team pushed a commit that referenced this pull request Jul 4, 2018
@magento-engcom-team
Copy link
Contributor

Hi @eduard13. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Wishlist Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants