Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.2] Use the new json serializer which throws an error when failing #16395

Closed
wants to merge 1 commit into from
Closed

[Backport 2.2] Use the new json serializer which throws an error when failing #16395

wants to merge 1 commit into from

Conversation

quisse
Copy link

@quisse quisse commented Jun 26, 2018 •
edited
Loading

Original Pull Request
#16154

Description

Use the new serializer which throws an error when json_encoding fails.

Fixed Issues (if relevant)

  1. Javascript error thrown from uiComponent 'notification_area' if messages are malformed #14937: Javascript error thrown from uiComponent 'notification_area' if messages are malformed
  2. Perhaps more

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

added json hex tag serializer and use it.
53b0126 
code formatting

Backwards compatibility fix

use JSON_HEX_TAG option for not breaking things

use new serializer instead of json_encode

use correct serializer in test

declare return type

use serializer

updated unit testing, now uses serializer

removed space

declare strict type
@magento-engcom-team
Copy link
Contributor

Hi @quisse. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@quisse quisse changed the title Use the new json serializer which throws an error when failing [Backport 2.2] Use the new json serializer which throws an error when failing Jun 26, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.6 milestone Jun 26, 2018
@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Jun 26, 2018 •
edited
Loading

Hi @VladimirZaets, let's wait when all things will be approved in original PR and only then accept this PR

@orlangur
Copy link
Contributor

@ihor-sviziev PR to 2.2-develop always should be processed first.

@quisse
Copy link
Author

quisse commented Jan 14, 2019

Closed in favor of #20271

@quisse quisse closed this Jan 14, 2019
@ghost
Copy link

ghost commented Jan 14, 2019

Hi @quisse, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@VladimirZaets VladimirZaets

Labels
Component: Checkout Component: Framework/Serialize Component: Ui Progress: on hold Release Line: 2.2
Projects
None yet
Milestone
Release: 2.2.8
Development

Successfully merging this pull request may close these issues.
6 participants
@quisse @magento-engcom-team @ihor-sviziev @orlangur @VladimirZaets @sidolov