-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
admin checkout agreement controllers refactor #16505
admin checkout agreement controllers refactor #16505
Conversation
Hi @AnshuMishra17. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hi @miguelbalparda, thank you for the review. |
/** | ||
* @var CheckoutAgreementsRepositoryInterface | ||
*/ | ||
protected $_agreementRepository; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, inject dependencies in classes when they are really needed.
Make new properties private and try to avoid usage leading underscore in var and methods name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been fixed.
Hi @sidolov, thank you for the review. |
Hi @AnshuMishra17. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
Description
Refactor the code by removing the direct use of ObjectManager and includes the dependencies using Constructor Dependency Injection
Manual testing scenarios