Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] Fixed Issue #11354 Merged CSS file name generation #16663

Merged
merged 9 commits into from
Jul 12, 2018
Merged

[Forwardport] Fixed Issue #11354 Merged CSS file name generation #16663

merged 9 commits into from
Jul 12, 2018

Conversation

mageprince
Copy link
Contributor

Original Pull Request

#15144
Fixed Issue #11354 Merged CSS file name generation

Description

When "Sign Static Files" option enabled at the Stores->Configuration->Advanced->Developer->Static Files Settings minified and merged CSS file md5 hash will be based on deployed version number.

This allows CSS code to be updated after each deploy at browser automatically. Previously you have to do CTRL+F5 after deploy to see CSS changes.

Fixed Issues (if relevant)

  1. Merged CSS file name generation #11354 : Merged CSS file name generation

Manual testing scenarios

  1. Stores->Configuration->Advanced->Developer set CSS Settings Merge and Minify CSS Files to YES
  2. Stores->Configuration->Advanced->Developer set JavaScript Settings Merge and Minify JavaScript Files to YES
  3. Stores->Configuration->Advanced->Developer->Static Files Settings set Sign Static Files tp YES
  4. Delete static content & deploy the static content again
  5. Remember the CSS filename
  6. Delete static content & deploy the static content again
  7. Compare to CSS file name to the file name ftop step 5. They should be different because the version of deployed files changed.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @mageprince. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @mageprince. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

@mageprince mageprince deleted the 2.3-develop-PR-port-15144 branch July 12, 2018 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants