Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare module namespace before template path in Magento_Reports and Magento_Review #16700

Closed
wants to merge 2 commits into from
Closed

Declare module namespace before template path in Magento_Reports and Magento_Review #16700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4496e9
Merge pull request #7 from magento/2.3-develop
mageprince Jul 9, 2018
f30b65e
Declare module namespace
mageprince Jul 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/code/Magento/Reports/Block/Adminhtml/Product/Viewed.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class Viewed extends \Magento\Backend\Block\Widget\Grid\Container
/**
* @var string
*/
protected $_template = 'report/grid/container.phtml';
protected $_template = 'Magento_Reports::report/grid/container.phtml';

/**
* @return void
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Reports/Block/Adminhtml/Sales/Bestsellers.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class Bestsellers extends \Magento\Backend\Block\Widget\Grid\Container
*
* @var string
*/
protected $_template = 'report/grid/container.phtml';
protected $_template = 'Magento_Reports::report/grid/container.phtml';

/**
* {@inheritdoc}
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Reports/Block/Adminhtml/Sales/Coupons.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class Coupons extends \Magento\Backend\Block\Widget\Grid\Container
*
* @var string
*/
protected $_template = 'report/grid/container.phtml';
protected $_template = 'Magento_Reports::report/grid/container.phtml';

/**
* {@inheritdoc}
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Reports/Block/Adminhtml/Sales/Invoiced.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class Invoiced extends \Magento\Backend\Block\Widget\Grid\Container
*
* @var string
*/
protected $_template = 'report/grid/container.phtml';
protected $_template = 'Magento_Reports::report/grid/container.phtml';

/**
* {@inheritdoc}
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Reports/Block/Adminhtml/Sales/Refunded.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class Refunded extends \Magento\Backend\Block\Widget\Grid\Container
*
* @var string
*/
protected $_template = 'report/grid/container.phtml';
protected $_template = 'Magento_Reports::report/grid/container.phtml';

/**
* {@inheritdoc}
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Reports/Block/Adminhtml/Sales/Sales.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class Sales extends \Magento\Backend\Block\Widget\Grid\Container
*
* @var string
*/
protected $_template = 'report/grid/container.phtml';
protected $_template = 'Magento_Reports::report/grid/container.phtml';

/**
* {@inheritdoc}
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Reports/Block/Adminhtml/Sales/Shipping.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class Shipping extends \Magento\Backend\Block\Widget\Grid\Container
*
* @var string
*/
protected $_template = 'report/grid/container.phtml';
protected $_template = 'Magento_Reports::report/grid/container.phtml';

/**
* {@inheritdoc}
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Reports/Block/Adminhtml/Sales/Tax.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class Tax extends \Magento\Backend\Block\Widget\Grid\Container
*
* @var string
*/
protected $_template = 'report/grid/container.phtml';
protected $_template = 'Magento_Reports::report/grid/container.phtml';

/**
* {@inheritdoc}
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Reports/Block/Adminhtml/Wishlist.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class Wishlist extends \Magento\Backend\Block\Template
*
* @var string
*/
protected $_template = 'report/wishlist.phtml';
protected $_template = 'Magento_Reports::report/wishlist.phtml';

/**
* Reports wishlist collection factory
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Review/Block/Adminhtml/Rating/Edit/Tab/Form.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class Form extends \Magento\Backend\Block\Widget\Form\Generic
/**
* @var string
*/
protected $_template = 'rating/form.phtml';
protected $_template = 'Magento_Review::rating/form.phtml';

/**
* Session
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Review/Block/Adminhtml/Rss/Grid/Link.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class Link extends \Magento\Framework\View\Element\Template
/**
* @var string
*/
protected $_template = 'rss/grid/link.phtml';
protected $_template = 'Magento_Review::rss/grid/link.phtml';

/**
* @var \Magento\Framework\App\Rss\UrlBuilderInterface
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Review/Block/Customer/Recent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class Recent extends \Magento\Framework\View\Element\Template
*
* @var string
*/
protected $_template = 'customer/list.phtml';
protected $_template = 'Magento_Review::customer/list.phtml';

/**
* Product reviews collection
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Review/Block/Customer/View.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class View extends \Magento\Catalog\Block\Product\AbstractProduct
*
* @var string
*/
protected $_template = 'customer/view.phtml';
protected $_template = 'Magento_Review::customer/view.phtml';

/**
* Catalog product model
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Review/Block/Rating/Entity/Detailed.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class Detailed extends \Magento\Framework\View\Element\Template
/**
* @var string
*/
protected $_template = 'detailed.phtml';
protected $_template = 'Magento_Review::detailed.phtml';

/**
* @var \Magento\Review\Model\RatingFactory
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Review/Block/View.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class View extends \Magento\Catalog\Block\Product\AbstractProduct
*
* @var string
*/
protected $_template = 'view.phtml';
protected $_template = 'Magento_Review::view.phtml';

/**
* Rating option model
Expand Down