Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix _utilities.less font-size issue #16716

Merged
merged 1 commit into from
Jul 13, 2018
Merged

fix _utilities.less font-size issue #16716

merged 1 commit into from
Jul 13, 2018

Conversation

Karlasa
Copy link
Contributor

@Karlasa Karlasa commented Jul 11, 2018

Description

Toolbar pager item has font-size atribute twice, should be defined only once.

Fixed Issues (if relevant)

none

Manual testing scenarios

look product toolbar pager number css
should be:

.pages .item {
font-size: 1.2rem;
...
}

is:
.pages .item {
font-size: 1.2rem;
font-size: 12px;
...
}

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@Karlasa
Copy link
Contributor Author

Karlasa commented Jul 11, 2018

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa, here is your new Magento instance.
Admin access: https://pr-16716.engcom.dev.magento.com/admin
Login: admin Password: 123123q

@Karlasa
Copy link
Contributor Author

Karlasa commented Jul 11, 2018

good, fix works as intended

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa. Thank you for your contribution.
We will aim to release these changes as part of 2.2.6.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@Karlasa
Copy link
Contributor Author

Karlasa commented Jul 14, 2018

@magento-engcom-team 2.1 and 2.3 ports allready referenced :)

magento-engcom-team added a commit that referenced this pull request Jul 15, 2018
…6755

 - Merge Pull Request #16755 from Karlasa/magento2:BP-PR-16716
 - Merged commits:
   1. f7160a2
magento-engcom-team pushed a commit that referenced this pull request Jul 15, 2018
Accepted Public Pull Requests:
 - #16825: [Backport] Fixed type hints and docs for Downloadable Samples block (by @ronak2ram)
 - #16836: [Backport] Fixed typo in SynonymGroupRepositoryInterface (by @mage2pratik)
 - #16755: [backport] #16716 fix _utilities.less font-size issue (by @Karlasa)
magento-engcom-team added a commit that referenced this pull request Jul 18, 2018
…16756

 - Merge Pull Request #16756 from Karlasa/magento2:FP-PR-16716
 - Merged commits:
   1. 040e396
   2. a031ef5
magento-engcom-team pushed a commit that referenced this pull request Jul 18, 2018
Accepted Public Pull Requests:
 - #16824: [Forwardport] Fixed type hints and docs for Downloadable Samples block (by @ronak2ram)
 - #16815: [Forwardport] Covered Magento\Checkout\Model\Cart\CollectQuote by Unit Test (by @mage2pratik)
 - #16756: [forwardport] #16716 fix _utilities.less font-size issue (by @Karlasa)
 - #16363: [Forwardport] Fix case mismatch call (class/method) (by @lfluvisotto)
 - #16745: [Forwardport] typo in private method name getUniq[ue]ImageIndex (by @eduard13)
 - #15895: Handle type errors for objects creation (by @yuriyDne)
 - #16874: [Forwardport] Remove commented code & remove space (by @ronak2ram)
 - #16773: Improved code and remove unnecessary space (by @ronak2ram)
@Karlasa Karlasa deleted the utilities-fix branch July 21, 2018 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants