-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix _utilities.less font-size issue #16716
fix _utilities.less font-size issue #16716
Conversation
Hi @Karlasa. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
@magento-engcom-team give me test instance |
Hi @Karlasa. Thank you for your request. I'm working on Magento instance for you |
Hi @Karlasa, here is your new Magento instance. |
good, fix works as intended |
Hi @Karlasa. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
@magento-engcom-team 2.1 and 2.3 ports allready referenced :) |
Accepted Public Pull Requests: - #16825: [Backport] Fixed type hints and docs for Downloadable Samples block (by @ronak2ram) - #16836: [Backport] Fixed typo in SynonymGroupRepositoryInterface (by @mage2pratik) - #16755: [backport] #16716 fix _utilities.less font-size issue (by @Karlasa)
Accepted Public Pull Requests: - #16824: [Forwardport] Fixed type hints and docs for Downloadable Samples block (by @ronak2ram) - #16815: [Forwardport] Covered Magento\Checkout\Model\Cart\CollectQuote by Unit Test (by @mage2pratik) - #16756: [forwardport] #16716 fix _utilities.less font-size issue (by @Karlasa) - #16363: [Forwardport] Fix case mismatch call (class/method) (by @lfluvisotto) - #16745: [Forwardport] typo in private method name getUniq[ue]ImageIndex (by @eduard13) - #15895: Handle type errors for objects creation (by @yuriyDne) - #16874: [Forwardport] Remove commented code & remove space (by @ronak2ram) - #16773: Improved code and remove unnecessary space (by @ronak2ram)
Description
Toolbar pager item has font-size atribute twice, should be defined only once.
Fixed Issues (if relevant)
none
Manual testing scenarios
look product toolbar pager number css
should be:
.pages .item {
font-size: 1.2rem;
...
}
is:
.pages .item {
font-size: 1.2rem;
font-size: 12px;
...
}
Contribution checklist