Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fix for #12081: missing translations in the js-translations.json #16720

Conversation

sanganinamrata
Copy link
Member

Original Pull Request

#13528

Description

This PR adds an additional pattern to the module responsible for generating the js-translations.json file. The translation routine doesn't translate strings in tags like<translate args="This won't be translated".

This is related to (but doesn't fix) #13471 where the Html parser of the phrase collection module is also missing a pattern matching the <translate args= tags.

Fixed Issues (if relevant)

  1. Magento 2.2.0: Translations for 'Item in Cart' missing in mini cart. #12081: Magento 2.2.0: Translations for 'Item in Cart' missing in mini cart.

Manual testing scenarios

  1. Clean Magento installation with a translation file translating the string "Item in Cart" from Magento_Checkout.
  2. Run setup:static-content:deploy
  3. Without the fix, the string isn't in the generated js-translations.json file. With the fix it will be.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @sanganinamrata. Thank you for your contribution.
We will aim to release these changes as part of 2.1.15.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants