Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] FIX for apparently random API failures while using array types #16828

Merged
merged 1 commit into from
Jul 17, 2018
Merged

[Backport] FIX for apparently random API failures while using array types #16828

merged 1 commit into from
Jul 17, 2018

Conversation

ronak2ram
Copy link
Member

@ronak2ram ronak2ram commented Jul 15, 2018

Original Pull Request

#16137

Description

Magento2 web-api is based on the Interface doctype, but if the developer is using CR+LF end-of-line, the \Magento\Framework\Reflection\TypeProcessor class is not able to determine the class name on array types.

This was caused by a wrong regex non including \r in \Magento\Framework\Reflection\TypeProcessor::getParamType.

Additional note: Magento 2.2-develop seems to be not affected by this.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

… webapi Interface class was using CR+LF end-of-line, TypeProcessor class was not able to determine the class name when an array was used.
@magento-engcom-team
Copy link
Contributor

Hi @ronak2ram. Thank you for your contribution.
We will aim to release these changes as part of 2.1.15.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants