[Backport] Fix error when generating urn catalog for empty misc.xml #16902
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#11686
Fix error when generating urn catalog for empty misc.xml
Description
Fix error when generating urn catalog for existing empty
misc.xml
. I fixed this by creating another DomDocumentFactory, for PhpStorm specificmisc.xml
. This factory checks if the passed data is empty, and if so, create themisc.xml
xml structure that\Magento\Developer\Model\XmlCatalog\Format\PhpStorm
expects.I also changed
\Magento\Framework\DomDocument\DomDocumentFactory
to follow the Magento 2 guidelines and added a Test class for this factory to define the behavior.Fixed Issues (if relevant)
Manual testing scenarios
rm .idea/misc..xml
touch .idea/misc.xml
bin/magento dev:urn-catalog:generate .idea/misc.xml
Contribution checklist