Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Trim issue on customer confirmation form #16986

Conversation

gelanivishal
Copy link
Contributor

Original Pull Request

#16595

Related to issue: #6058

Description

Trim email address by remove leading or trailing space in confirmation form

Fixed Issues (if relevant)

  1. IE11 user login email validation fails if field has leading or trailing space #6058: IE11 user login email validation fails if field has leading or trailing space

Manual testing scenarios

  1. Open customer confirmation page in Firefox or IE browser.
  2. Try to add space before entering an email address in the Email field.
  3. Copy " johndoe@domain.com " and paste in the Email field. It will automatically remove leading or trailing space.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-2453 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution.
We will aim to release these changes as part of 2.1.15.
Please check the release notes for final confirmation.

@matthiashamacher
Copy link

matthiashamacher commented Feb 5, 2019

Hi @magento-engcom-team @gelanivishal,
In Magento 2.1 this change causes an error, because it calls the method escapeHtmlAttr on the block, but the method does not exists in Magento\Framework\View\Element\AbstractBlock in Magento 2.1.
The method is added to the class with module version 101.0.0.
As a result you see an empty page if you call /customer/account/confirmation.
<?= $block->escapeHtmlAttr($block->getEmail()) ?>
must be changed back to
<?php echo $this->helper(\Magento\Framework\EscapeHelper::class)->escapeHtmlAttr($block->getEmail()) ?> to fix this problem.

Best Matthias

@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Feb 5, 2019

Hi @matthiashamacher,
Could you create separate issue for this or even better PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants