-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct return type of methods #16988
Correct return type of methods #16988
Conversation
Hi @mage2pratik. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
@@ -55,7 +55,7 @@ public function processAttributeValue($attribute, $value); | |||
* | |||
* @param array $index | |||
* @param string $separator | |||
* @return string | |||
* @return array |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix PHPDocs of all implementations as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I meant https://github.com/magento/magento2/blame/2.2-develop/app/code/Magento/CatalogSearch/Model/ResourceModel/Engine.php#L123 and it is already fixed. Should pull changes for 2.2-develop
more frequently to my local.
Hi @orlangur, thank you for the review. |
Hi @mage2pratik. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
Description
Correct return type of methods.
Fixed Issues (if relevant)
Manual testing scenarios
N/A
Contribution checklist