Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] Microrefactoring in product gallery block helper #17147

Closed
wants to merge 1 commit into from
Closed

[Forwardport] Microrefactoring in product gallery block helper #17147

wants to merge 1 commit into from

Conversation

mage2pratik
Copy link
Contributor

@mage2pratik mage2pratik commented Jul 25, 2018

Original Pull Request

#16889

Description

Microrefactoring in product gallery block helper

Fixed Issues (if relevant)

No

Manual testing scenarios

No

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik
Thank you for your contribution. This pull request has been combined (merged) with #17133 to optimize pull requests queue on magento/magento2 repository
Closing this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants