-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] Fix for #14593 (second try #16431) #17223
[Backport] Fix for #14593 (second try #16431) #17223
Conversation
event.stopImmediatePropagation(); | ||
|
||
/** @inheritdoc */ | ||
always: function (e) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you describe why this code was added? I can't find this change in original PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, just in order to be the same across all release lines. It's a good idea.
event.stopImmediatePropagation(); | ||
|
||
/** @inheritdoc */ | ||
always: function (e) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, just in order to be the same across all release lines. It's a good idea.
Hi @ihor-sviziev, thank you for the review. |
Hi @gelanivishal. Thank you for your contribution. |
Original Pull Request
#16477
Description
Preconditions:
Magento version 2.2.4 with luma theme
Step to reproduce:
Expected Result
Actual result
https://github.com/magento/magento2/blob/2.2-develop/app/code/Magento/Checkout/view/frontend/web/js/sidebar.js#L96
Fixed Issues
P.S.
First, pull request - #16431
Contribution checklist