Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fix for #14593 (second try #16431) #17223

Conversation

gelanivishal
Copy link
Contributor

Original Pull Request

#16477

Description

Preconditions:

Magento version 2.2.4 with luma theme

Step to reproduce:

  • Open chrome developer console
  • Add a product to the cart.
  • From the mini cart in the upper right click the trash icon.
  • A confirmation modal will open.
  • Press Esc button

Expected Result

  • Close the confirm

Actual result

  • js error

https://github.com/magento/magento2/blob/2.2-develop/app/code/Magento/Checkout/view/frontend/web/js/sidebar.js#L96

Uncaught TypeError: Cannot read property 'stopImmediatePropagation' of undefined

2018-06-21 15-50-01

Fixed Issues

  1. Press Esc Key on modal generate a jquery UI error #14593

P.S.

First, pull request - #16431

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

event.stopImmediatePropagation();

/** @inheritdoc */
always: function (e) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you describe why this code was added? I can't find this change in original PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, just in order to be the same across all release lines. It's a good idea.

event.stopImmediatePropagation();

/** @inheritdoc */
always: function (e) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, just in order to be the same across all release lines. It's a good idea.

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-2595 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution.
We will aim to release these changes as part of 2.1.15.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants