Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Refactored multiples conditions which could be grouped in a single on… #17233

Closed
wants to merge 1 commit into from
Closed

[Backport] Refactored multiples conditions which could be grouped in a single on… #17233

wants to merge 1 commit into from

Conversation

tiagosampaio
Copy link
Member

@tiagosampaio tiagosampaio commented Jul 28, 2018

Original Pull Request

#17123
Some conditions were divided in multiple ones when it was not really necessary in captcha extension

Description

Some captcha observers contained multiple conditions when it was not necessary

Fixed Issues (if relevant)

Code style improvement

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Original PR
#17123

Sorry, something went wrong.

@magento-engcom-team
Copy link
Contributor

Hi @tiagosampaio. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ihor-sviziev
Copy link
Contributor

Hi @tiagosampaio,
We already have backport to 2.2 PR: #17203
I'm closing this PR as duplicate.

@ihor-sviziev ihor-sviziev self-assigned this Jul 28, 2018
@tiagosampaio tiagosampaio deleted the 2.2-develop-PR-port-17123 branch August 7, 2018 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants