Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Resolved : Mobile device style groups incorrect order #17240

Merged
merged 1 commit into from
Aug 1, 2018
Merged

[Backport] Resolved : Mobile device style groups incorrect order #17240

merged 1 commit into from
Aug 1, 2018

Conversation

tiagosampaio
Copy link
Member

Original Pull Request

#16959

Description

Style groups for mobile devices (max-width) are specified in the wrong order.

In lib/web/css/source/lib/_responsive.less the style groups run breakpoint-size ascending: 319px, 479px, 639px, 767px, which leads to outputting max-width media queries breakpoint-size ascending - the last-defined breakpoint overrides smaller screen size breakpoints...

Fixed Issues (if relevant)

Style groups for mobile devices (max-width) are specified in the wrong order.

  1. magento/magento2Mobile device style groups incorrect order in _responsive.less #14476: Mobile device style groups incorrect order in _responsive.less
  2. ...

Expected result

CSS should be output as follows:

@media only screen and (max-width: 479px) {
  .logo {
    max-width: 140px;
  }
}
@media only screen and (max-width: 639px) {
  .logo {
    max-width: 165px;
  }
}

Actual result

CSS is output as follows:

@media only screen and (max-width: 639px) {
  .logo {
    max-width: 165px;
  }
}
@media only screen and (max-width: 479px) {
  .logo {
    max-width: 140px;
  }
}

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-2562 has been created to process this Pull Request

@ihor-sviziev
Copy link
Contributor

Hi @tejash-wagento,
Please do not close such PRs. They were already approved and probably they might be already tested.
As author of original PR you will get 5 points even not your PR was accepted.
Details: https://github.com/magento/magento2/wiki/Contribution-Rewards#base-achievements

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-2605 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @tiagosampaio. Thank you for your contribution.
We will aim to release these changes as part of 2.1.15.
Please check the release notes for final confirmation.

@tiagosampaio tiagosampaio deleted the 2.1-develop-PR-port-16959 branch August 7, 2018 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants