Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Corrected block name in Magento_Framework's test xml file. #17407

Closed
wants to merge 1 commit into from
Closed

[Backport] Corrected block name in Magento_Framework's test xml file. #17407

wants to merge 1 commit into from

Conversation

jignesh-baldha
Copy link
Member

Original Pull Request

#16646

Description

Corrected block name in Magento_Framework's test XML file. block name was written wrong in group.xml file.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@sidolov
Copy link
Contributor

sidolov commented Aug 7, 2018

Hi @jignesh-baldha , due to changes in Magento Code Contributions Guide we can't accept such Pull Requests to 2.1 release line. All code cleanup like typos, spelling mistakes, removing unused code, etc should be delivered to 2.3 release line.
Thank you!

@sidolov sidolov closed this Aug 7, 2018
@jignesh-baldha jignesh-baldha changed the title Corrected block name in Magento_Framework's test xml file. [Backport] Corrected block name in Magento_Framework's test xml file. Aug 7, 2018
@jignesh-baldha
Copy link
Member Author

@sidolov I can create backport or not?

@jignesh-baldha jignesh-baldha reopened this Aug 7, 2018
@sidolov
Copy link
Contributor

sidolov commented Aug 7, 2018

The rules described in Magento Code Contributions Guide applies to all pull requests, including ports to 2.1 and 2.2 release lines. You may create the port to 2.3 release line if it not exists.

@sidolov sidolov closed this Aug 7, 2018
@jignesh-baldha jignesh-baldha deleted the back-port-pull-16646 branch August 16, 2018 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants