Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] Improvements in UI component MassActions #17446

Merged
merged 3 commits into from
Aug 11, 2018
Merged

[Forwardport] Improvements in UI component MassActions #17446

merged 3 commits into from
Aug 11, 2018

Conversation

arendarenko
Copy link
Contributor

@arendarenko arendarenko commented Aug 8, 2018

Original Pull Request

#17437

Description

This improvements makes work with UI Grids and MassActions (which are using together) more comfortable. I had experienced cases when admin user accidentally delete all data when working with grids in backend (example: customers, orders, content, catalog) because by default when you're clicking on top checkbox in MassActions component, it's selects not only visible on page records (which is expectable), but all the records.

List of changes:

  • Changed default behavior when clicking on checkbox on the top of grid from select all records to select all visible records in modules: Catalog, Sales, Customers, Users, Content.
  • Changed popup message when doing mass action (example - deleting records) in modules Catalog, Sales, Customers, Users, Content. Now you can see number of records which will be affected.

Manual testing scenarios

  1. Login as admin user
  2. Go to module which contain UI Grid (example: Catalog, Sales, Customers, Users, Content)
  3. Click on the top checkox in grid header
  4. Ensure that you selected only visible on page records, but not all the records that you have in grid.
  5. After selecting records, choose mass action "Delete" and ensure that in popup message now you will see count of records which will be affected.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

- Update confirm message method, add number of selected records to confirm message
- Add multiselect.js new method that toggles page records and set it using in template and set up it in template file
@magento-engcom-team
Copy link
Contributor

Hi @alexeya-ven. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-2711 has been created to process this Pull Request

- Code refactoring according to Magento code standards
@magento-engcom-team
Copy link
Contributor

Hi @alexeya-ven. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants