Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Make it possible to disable cross-sell on cart page #17482

Closed

Conversation

gelanivishal
Copy link
Contributor

Original Pull Request

#16569

Description

To be able to select whether to have the cross-sell active on the cart page an admin configuration is created under Stores > Configuration > Sales > Checkout > Shopping Cart.

The default for this setting is set to Yes (Show cross-sell items). This is for backwards compatibility and not have webshop owners accidentally not showing these items.

Because this is now sorted as the 3rd configuration in this section/group the extra configurations for the grouped product image and the configurable product image are now also increased.

This feature will make it possible to have this cross-sell turned off during special sales, A/B testing or in a specific store view.

Manual testing scenarios

  1. Set up a cross-sell
  2. Add that product that has the cross-sell product configured to your cart
  3. Go to the shopping cart
  4. See that cross-sell is shown
  5. Change the new setting 'Show Crosssell Items in the Shopping Cart' to 'No' (setting is under Stores > Configuration > Sales > Checkout > Shopping Cart)
  6. Refresh affected caches
  7. Go back to the shopping cart
  8. See that cross-sell is not shown

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sidolov
Copy link
Contributor

sidolov commented Aug 10, 2018

Hi @gelanivishal , due to changes in Magento Code Contributions Guide we can't accept such Pull Requests to 2.1 release line. New features and improvements should be delivered to 2.3 release line.
Thank you!

@sidolov sidolov closed this Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants