Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize code to remove phpmd suppress warnings #17805

Merged
merged 3 commits into from
Nov 5, 2018
Merged

Optimize code to remove phpmd suppress warnings #17805

merged 3 commits into from
Nov 5, 2018

Conversation

arnoudhgz
Copy link
Contributor

Description

By making the order of some checks more efficient the suppress warnings in these two files about CyclomaticComplexity and NPathComplexity.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: MediaCT Pull Request is created by partner MediaCT partners-contribution Pull Request is created by Magento Partner Component: Customer Component: Eav labels Aug 26, 2018
@magento-engcom-team
Copy link
Contributor

Hi @arnoudhgz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

orlangur
orlangur reviewed Aug 27, 2018
View reviewed changes
app/code/Magento/Customer/Model/Metadata/Form/Text.php Outdated
* @param string $value
* @param string $entityTypeCode
* @param bool $isAjax
* @param \Magento\Framework\Stdlib\StringUtils $stringHelper
* @param StringUtils $stringHelper
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to avoid such changes, they should be done as separate efforts.

@arnoudhgz
Optimize code to remove phpmd suppress warnings
adb3af2 
By making the order of some checks more efficient the suppress warnings
in these two files about CyclomaticComplexity and NPathComplexity.
@arnoudhgz
Copy link
Contributor Author

@orlangur I updated the PR to only solve the suppress warnings issues, the import statements have been undone.

@ishakhsuvarov ishakhsuvarov added this to the Release: 2.3.1 milestone Sep 18, 2018
ihor-sviziev
ihor-sviziev requested changes Sep 21, 2018
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @arnoudhgz,
In general - looks good, but there are some tests that are failing. Could you look into it?

@ihor-sviziev ihor-sviziev self-assigned this Sep 21, 2018
@ihor-sviziev
Copy link
Contributor

Hi @arnoudhgz,
Will you be able to look at failing tests? Maybe you need some help? Of so - you can contact me at Slack

@arnoudhgz
Copy link
Contributor Author

@ihor-sviziev I think later this week I will look into it. Have been busy for a while.

@arnoudhgz
Copy link
Contributor Author

@ihor-sviziev I used a wrong method, it is solved now

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-3326 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit f5b496c into magento:2.3-develop Nov 5, 2018
@magento-engcom-team
Copy link
Contributor

Hi @arnoudhgz. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

magento-engcom-team pushed a commit that referenced this pull request Nov 5, 2018
ENGCOM-3326: Optimize code to remove phpmd suppress warnings #17805
10d14d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlangur orlangur orlangur left review comments

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@ihor-sviziev ihor-sviziev

Labels
Component: Customer Component: Eav Partner: MediaCT Pull Request is created by partner MediaCT partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.1
Development

Successfully merging this pull request may close these issues.
5 participants
@arnoudhgz @magento-engcom-team @ihor-sviziev @orlangur @ishakhsuvarov