Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Update issue templates for Magento 2 GitHub project #17859

Closed
wants to merge 1 commit into from
Closed

[Backport] Update issue templates for Magento 2 GitHub project #17859

wants to merge 1 commit into from

Conversation

mage2pratik
Copy link
Contributor

Original Pull Request

#17817

Description

This pull request adds more templates to the Issue Reporting section of the GitHub. New templates are targeting a broader scope of possible problems and proposed descriptions are aimed at simplifying future fixes.

Proposed set of templates currently cover:

  • Bug report (same, default bug report template)
  • Developer experience issue (Issues related directly to the application design and architecture, for example: modularity, extensibility, ability to customize, etc.)
  • Feature requests (clarifies, that separate project is used for that, requests minimum input and description)

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

To improve flow for submitting an issue to Magento 2 GitHub issue templates for different situations are added.
@osrecio osrecio self-assigned this Aug 30, 2018
@osrecio osrecio self-requested a review August 30, 2018 07:35
@magento-engcom-team magento-engcom-team added this to the Release: 2.1.16 milestone Aug 30, 2018
@magento-engcom-team
Copy link
Contributor

Hi @osrecio, thank you for the review.
ENGCOM-2897 has been created to process this Pull Request

@ishakhsuvarov
Copy link
Contributor

Hi @mage2pratik @osrecio
I don't think these changes are required in the 2.1-develop branch. GitHub UI only pulls templates from the default repo branch and it doesn't seem like we will make 2.1 default in the future :)

@osrecio
Copy link
Member

osrecio commented Aug 30, 2018

Yes you're right @ishakhsuvarov . I will only accept 2.3-develop PR.

I will close this PR. If something change with branches I will re-open.

@osrecio osrecio closed this Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants