Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] Specify the table when adding field in massAction filter #17866

Closed
wants to merge 1 commit into from
Closed

Conversation

adaudenthun
Copy link
Contributor

@adaudenthun adaudenthun commented Aug 30, 2018

Hi!
About the MassAction in admin Grid. When have a custom grid and apply custom \Magento\Sales\Model\ResourceModel\Order\Grid\Collection and override _initSelect for add join group etc ...
So, when we join some tables, we have the error 'ambiguous column name'.

Fixed Issues (if relevant)

  1. Specify the table when adding field when applySelectionOnTargetProvider() in Magento\Ui\Component\MassAction\Filter.php #17863: Specify the table when adding field when applySelectionOnTargetProvider() in Magento\Ui\Component\MassAction\Filter.php

Manual testing scenarios

  1. Have a custom collection grid like :
    class Collection extends \Magento\Sales\Model\ResourceModel\Order\Grid\Collection { protected function _initSelect() { parent::_initSelect(); $this->getSelect() ->join('XXXXXX') ->group("XXXXX"); return $this; } }
  2. Try to apply a mass action

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Original PR

#17864

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Aug 30, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @adaudenthun. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sidolov
Copy link
Contributor

sidolov commented Aug 30, 2018

Hi @adaudenthun , looks like email from commit is different than in your GitHub profile, please, add email from commit to your Github profile and sign CLA, otherwise we can't proceed with your PR.
Thank you!

@adaudenthun
Copy link
Contributor Author

adaudenthun commented Aug 30, 2018

Hi @sidolov ,

Normaly now it's ok , i add this.

thanks

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Aug 31, 2018
@sidolov sidolov changed the title Specify the table when adding field in massAction filter [Forwardport] Specify the table when adding field in massAction filter Sep 3, 2018
@sidolov
Copy link
Contributor

sidolov commented Sep 20, 2018

Hi @adaudenthun , I'm closing this PR because original #17864 was closed due to inactivity.
Please, reopen it if you wish to continue.
Thank you for the contribution!

@sidolov sidolov closed this Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants