Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Specify the table when adding field in massAction filter #17867

Closed
wants to merge 1 commit into from
Closed

[Backport] Specify the table when adding field in massAction filter #17867

wants to merge 1 commit into from

Conversation

adaudenthun
Copy link
Contributor

@adaudenthun adaudenthun commented Aug 30, 2018

Hi!
About the MassAction in admin Grid. When have a custom grid and apply custom \Magento\Sales\Model\ResourceModel\Order\Grid\Collection and override _initSelect for add join group etc ...
So, when we join some tables, we have the error 'ambiguous column name'.

Fixed Issues (if relevant)

  1. Specify the table when adding field when applySelectionOnTargetProvider() in Magento\Ui\Component\MassAction\Filter.php #17863: Specify the table when adding field when applySelectionOnTargetProvider() in Magento\Ui\Component\MassAction\Filter.php

Manual testing scenarios

  1. Have a custom collection grid like :
    class Collection extends \Magento\Sales\Model\ResourceModel\Order\Grid\Collection { protected function _initSelect() { parent::_initSelect(); $this->getSelect() ->join('XXXXXX') ->group("XXXXX"); return $this; } }
  2. Try to apply a mass action

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Original PR

#17864

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Aug 30, 2018

CLA assistant check
All committers have signed the CLA.

@sidolov
Copy link
Contributor

sidolov commented Aug 30, 2018

Hi @adaudenthun , looks like email from commit is different than in your GitHub profile, please, add email from commit to your Github profile and sign CLA, otherwise we can't proceed with your PR.
Thank you!

@adaudenthun
Copy link
Contributor Author

adaudenthun commented Aug 30, 2018

Hi @sidolov ,

Normaly now it's ok , i add this.

thanks

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-2903 has been created to process this Pull Request

@sidolov sidolov changed the title Specify the table when adding field in massAction filter [Backport] Specify the table when adding field in massAction filter Sep 3, 2018
@ishakhsuvarov
Copy link
Contributor

Hi @adaudenthun
Unfortunately we can not accept Pull Requests targeting 2.1 with changes that are not applied to 2.2 and 2.3.
Please feel free to reopen once newer versions have the fix delivered.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants