Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed child items showing on My Account order view #17889

Merged

Conversation

rogyar
Copy link
Contributor

@rogyar rogyar commented Sep 2, 2018

Description

On an attempt to view an order on My Account -> My Orders -> View Order page bundle products are displayed without child items. It's an expected behavior since on the Print Order (invoice and shipment as well) a customer is able to see children items of a bundle product.

On building pagination logic for ordered items, the children items were excluded from the list (accidentally or for a purpose). This PR removes this step so all children products are displayed on the order view page (so we have the same behavior everywhere: on the order view page, print pages etc). As for the pagination, after the fix, it counts all products: parent and child upon building the products count and pages. However, it's not an issue since bundle products with the child items make a quite long list of information and it's a good idea to use pagination in that case.

Fixed Issues (if relevant)

  1. Bundle Product Options not showing in Customer Account - Items Ordered  #16434: Bundle Product Options not showing in Customer Account - Items Ordered

Manual testing scenarios

  1. Clean Magento installation from 2.2-develop branch with sample data installed.
  2. Customize and buy "Sprite Yoga Companion Kit" bundle product as a logged in customer.
  3. Go to My Account -> My Orders and view the recent order.
  4. You should see information about the child items of the bundle product

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Component: Sales Release Line: 2.2 labels Sep 2, 2018
@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@nuzil nuzil self-assigned this Sep 3, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.7 milestone Sep 3, 2018
@magento-engcom-team
Copy link
Contributor

Hi @nuzil, thank you for the review.
ENGCOM-2911 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Award: bug fix Component: Sales Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants