Fix invalid @method phpdoc to prevent prophecy mocking error #1792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tkotosz, thank you for contribution! CR: passed |
|
@okorshenko I have updated the PR since this issue appeared in other classes as well. (I also rebased my branch in order to not conflict with the current develop) |
tkotosz
force-pushed
the
fix/prophecy-doubler-error-for-product-model
branch
from
30df492 to
8141174
Compare
tkotosz
force-pushed
the
fix/prophecy-doubler-error-for-product-model
branch
from
8141174 to
b15d950
Compare
|
We have automated a Magento Contributor License Agreement verifier for contributions sent to our GitHub projects. |
|
@tkotosz , could you please merge latest changes from develop branch? Thank you |
Conflicts: app/code/Magento/Catalog/Model/Product.php app/code/Magento/Reports/Block/Adminhtml/Shopcart/Abandoned/Grid.php
|
@okorshenko Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue - Invalid docblock prevent using Prophecy
I am trying to use Magento\Catalog\Model\Product with Prophecy (using phpspec) and I get the following error :
Fix
After I found this it turned out the Product class has invalid
@methodphpdoc here. So in order to fix this issue only this phpdoc need to be fixed.