-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented 17964: Backend Order creation Authorizenet: If invalid cr… #17986
Conversation
…edit card number is entered the loader keeps spinning forever without any error message
Hi @passtet. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
@@ -1170,8 +1170,10 @@ define([ | |||
|
|||
submit : function() | |||
{ | |||
jQuery('#edit_form').trigger('processStart'); | |||
jQuery('#edit_form').trigger('submitOrder'); | |||
if(jQuery('#edit_form').valid()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @passtet, please add space between if
and (
.
And what about move jQuery('#edit_form')
to a variable? Then use it to validate and trigger methods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@williankeller done. I would actually refactore the whole file for those, but I guess that there would be too many conflicts :)
… invalid credit card number is entered the loader keeps spinning forever without any error message
Hi @sidolov, thank you for the review. |
Hi @passtet. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
…edit card number is entered the loader keeps spinning forever without any error message
Description
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist