Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#17784 [CatalogImportExport][export] - added website store views to export #17997

Closed

Conversation

Yupik
Copy link
Contributor

@Yupik Yupik commented Sep 9, 2018

Description

I've added preloading of website store views, which are used to fill exported CSV file in column "store_view_code", which was empty.

Fixed Issues (if relevant)

  1. magento/magento2#17784: store_view_code column has empty values in csv

Manual testing scenarios

  1. Create few websites, stores, and store views
  2. Create few products, assign them to websites
  3. Export data to CSV

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Sep 9, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @Yupik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@Yupik Yupik force-pushed the ext/17784-export-website-store-view-fix branch from 9b30a7a to 097903c Compare September 11, 2018 11:42
@sidolov
Copy link
Contributor

sidolov commented Sep 18, 2018

Hi @Yupik , please, take a look at failed tests, looks like provided changes broke a lot of integration tests related to import/export

@sidolov sidolov self-assigned this Sep 18, 2018
@Yupik Yupik closed this Sep 19, 2018
@Yupik Yupik deleted the ext/17784-export-website-store-view-fix branch September 19, 2018 05:37
@Yupik
Copy link
Contributor Author

Yupik commented Sep 19, 2018

Hello @sidolov , i've seen it already, i'll take care about this after holidays.

@vpodorozh
Copy link
Contributor

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @vpodorozh. Thank you for your request. I'm working on Magento instance for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants