Fix module uninstall shell command and composer removal w/out regression #18002
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a discrepancy between
composer.lock
andcomposer.json
when removing a module viabin/magento module:uninstall
command. Also, the output is wrong and the guide says it should do otherwise.The removal option in the code solved the previous issue #5797 , but caused the new issue. The new change solves both.
Fixed Issues (if relevant)
Manual testing scenarios
bin/magento sampledata:deploy
bin/magento setup:upgrade
bin/magento module:uninstall Magento_CmsSampleData
Contribution checklist