Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Snake Case To Camel Case #18064

Conversation

hryvinskyi
Copy link
Member

Description

Refactoring SimpleDataObjectConverter class
and updated code where you can use SimpleDataObjectConverter

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @hryvinskyi. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Sep 15, 2018
@hryvinskyi hryvinskyi added Port and removed Port labels Sep 15, 2018
@magento-engcom-team magento-engcom-team added Component: Framework/App Component: Framework/Api USE ONLY for FRAMEWORK RELATED BUG! E.g If bug related to Catalog Service Contracts use just Catalog Component: Signifyd Component: Webapi Use with concrete module component label E.g. "Component: Webapi" + "Catalog" labels Sep 16, 2018
@ishakhsuvarov ishakhsuvarov modified the milestone: Release: 2.3.1 Sep 18, 2018
@magento-engcom-team magento-engcom-team merged commit 033e46b into magento:2.3-develop Oct 3, 2018
@magento-engcom-team
Copy link
Contributor

Hi @hryvinskyi. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

lewisvoncken pushed a commit to lewisvoncken/magento2 that referenced this pull request Oct 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Framework/Api USE ONLY for FRAMEWORK RELATED BUG! E.g If bug related to Catalog Service Contracts use just Catalog Component: Framework/App Component: Signifyd Component: Webapi Use with concrete module component label E.g. "Component: Webapi" + "Catalog" Event: lviv-meetup Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants