Fix bool scope config and update throws and update use clases

app/code/Magento/AdvancedSearch/Model/Recommendations/DataProvider.php

@@ -10,6 +10,9 @@
 use Magento\Search\Model\QueryInterface;
 use Magento\AdvancedSearch\Model\SuggestedQueriesInterface;
 
+/**
+ * Class DataProvider
+ */
 class DataProvider implements SuggestedQueriesInterface
 {
     /**
@@ -51,6 +54,8 @@ class DataProvider implements SuggestedQueriesInterface
     private $recommendationsFactory;
 
     /**
+     * DataProvider constructor.
+     *
      * @param ScopeConfigInterface $scopeConfig
      * @param \Magento\Catalog\Model\Layer\Resolver $layerResolver
      * @param \Magento\AdvancedSearch\Model\ResourceModel\RecommendationsFactory $recommendationsFactory
@@ -69,18 +74,24 @@ public function __construct(
     }
 
     /**
+     * Is Results Count Enabled
+     *
      * @return bool
      */
     public function isResultsCountEnabled()
     {
-        return (bool)$this->scopeConfig->getValue(
+        return $this->scopeConfig->isSetFlag(
             self::CONFIG_RESULTS_COUNT_ENABLED,
             ScopeInterface::SCOPE_STORE
         );
     }
 
     /**
-     * {@inheritdoc}
+     * Get Items
+     *
+     * @param QueryInterface $query
+     *
+     * @return array|\Magento\Search\Model\QueryResult[]
      */
     public function getItems(QueryInterface $query)
     {
@@ -102,6 +113,8 @@ public function getItems(QueryInterface $query)
     }
 
     /**
+     * Return Search Recommendations
+     *
      * @param QueryInterface $query
      * @return array
      */
@@ -126,17 +139,21 @@ private function getSearchRecommendations(\Magento\Search\Model\QueryInterface $
     }
 
     /**
+     * Is Search Recommendations Enabled
+     *
      * @return bool
      */
     private function isSearchRecommendationsEnabled()
     {
-        return (bool)$this->scopeConfig->getValue(
+        return $this->scopeConfig->isSetFlag(
             self::CONFIG_IS_ENABLED,
             ScopeInterface::SCOPE_STORE
         );
     }
 
     /**
+     * Return Search Recommendations Count
+     *
      * @return int
      */
     private function getSearchRecommendationsCount()

app/code/Magento/CatalogInventory/Model/Configuration.php

@@ -9,6 +9,7 @@
 use Magento\CatalogInventory\Helper\Minsaleqty as MinsaleqtyHelper;
 use Magento\Framework\App\Config\ScopeConfigInterface;
 use Magento\Catalog\Model\ProductTypes\ConfigInterface;
+use Magento\Store\Model\ScopeInterface;
 use Magento\Store\Model\StoreManagerInterface;
 
 /**
@@ -131,6 +132,8 @@ class Configuration implements StockConfigurationInterface
     protected $storeManager;
 
     /**
+     * Configuration constructor.
+     *
      * @param ConfigInterface $config
      * @param ScopeConfigInterface $scopeConfig
      * @param MinsaleqtyHelper $minsaleqtyHelper
@@ -149,7 +152,9 @@ public function __construct(
     }
 
     /**
-     * {@inheritdoc}
+     * Default Scope Id
+     *
+     * @return int
      */
     public function getDefaultScopeId()
     {
@@ -159,6 +164,8 @@ public function getDefaultScopeId()
     }
 
     /**
+     * Is Qty Type Ids
+     *
      * @param int|null $filter
      * @return array
      */
@@ -182,6 +189,8 @@ public function getIsQtyTypeIds($filter = null)
     }
 
     /**
+     * Is Qty
+     *
      * @param int $productTypeId
      * @return bool
      */
@@ -201,25 +210,29 @@ public function canSubtractQty($store = null)
     {
         return $this->scopeConfig->isSetFlag(
             self::XML_PATH_CAN_SUBTRACT,
-            \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
+            ScopeInterface::SCOPE_STORE,
             $store
         );
     }
 
     /**
+     * Get Min Qty
+     *
      * @param null|string|bool|int|\Magento\Store\Model\Store $store
      * @return float
      */
     public function getMinQty($store = null)
     {
         return (float)$this->scopeConfig->getValue(
             self::XML_PATH_MIN_QTY,
-            \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
+            ScopeInterface::SCOPE_STORE,
             $store
         );
     }
 
     /**
+     * Get Min Sale Qty
+     *
      * @param null|string|bool|int|\Magento\Store\Model\Store $store
      * @param int $customerGroupId
      * @return float
@@ -230,27 +243,31 @@ public function getMinSaleQty($store = null, $customerGroupId = null)
     }
 
     /**
+     * Get Max Sale Qty
+     *
      * @param null|string|bool|int|\Magento\Store\Model\Store $store
      * @return float|null
      */
     public function getMaxSaleQty($store = null)
     {
         return (float)$this->scopeConfig->getValue(
             self::XML_PATH_MAX_SALE_QTY,
-            \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
+            ScopeInterface::SCOPE_STORE,
             $store
         );
     }
 
     /**
+     * Get Notify Stock Qty
+     *
      * @param null|string|bool|int|\Magento\Store\Model\Store $store
      * @return float
      */
     public function getNotifyStockQty($store = null)
     {
         return (float) $this->scopeConfig->getValue(
             self::XML_PATH_NOTIFY_STOCK_QTY,
-            \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
+            ScopeInterface::SCOPE_STORE,
             $store
         );
     }
@@ -264,22 +281,24 @@ public function getNotifyStockQty($store = null)
      */
     public function getEnableQtyIncrements($store = null)
     {
-        return (bool) $this->scopeConfig->getValue(
+        return $this->scopeConfig->isSetFlag(
             self::XML_PATH_ENABLE_QTY_INCREMENTS,
-            \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
+            ScopeInterface::SCOPE_STORE,
             $store
         );
     }
 
     /**
+     * Get Qty Increments
+     *
      * @param null|string|bool|int|\Magento\Store\Model\Store $store
      * @return float
      */
     public function getQtyIncrements($store = null)
     {
         return (float)$this->scopeConfig->getValue(
             self::XML_PATH_QTY_INCREMENTS,
-            \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
+            ScopeInterface::SCOPE_STORE,
             $store
         );
     }
@@ -294,7 +313,7 @@ public function getBackorders($store = null)
     {
         return (int) $this->scopeConfig->getValue(
             self::XML_PATH_BACKORDERS,
-            \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
+            ScopeInterface::SCOPE_STORE,
             $store
         );
     }
@@ -309,7 +328,7 @@ public function getManageStock($store = null)
     {
         return (int) $this->scopeConfig->isSetFlag(
             self::XML_PATH_MANAGE_STOCK,
-            \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
+            ScopeInterface::SCOPE_STORE,
             $store
         );
     }
@@ -325,7 +344,7 @@ public function getCanBackInStock($store = null)
     {
         return $this->scopeConfig->isSetFlag(
             self::XML_PATH_CAN_BACK_IN_STOCK,
-            \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
+            ScopeInterface::SCOPE_STORE,
             $store
         );
     }
@@ -340,7 +359,7 @@ public function isShowOutOfStock($store = null)
     {
         return $this->scopeConfig->isSetFlag(
             self::XML_PATH_SHOW_OUT_OF_STOCK,
-            \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
+            ScopeInterface::SCOPE_STORE,
             $store
         );
     }
@@ -355,14 +374,13 @@ public function isAutoReturnEnabled($store = null)
     {
         return $this->scopeConfig->isSetFlag(
             self::XML_PATH_ITEM_AUTO_RETURN,
-            \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
+            ScopeInterface::SCOPE_STORE,
             $store
         );
     }
 
     /**
-     * Get 'Display product stock status' option value
-     * Shows if it is necessary to show product stock status ('in stock'/'out of stock')
+     * Display product stock status. Shows if it is necessary to show product stock status in stock/out of stock.
      *
      * @param null|string|bool|int|\Magento\Store\Model\Store $store
      * @return bool
@@ -371,12 +389,14 @@ public function isDisplayProductStockStatus($store = null)
     {
         return $this->scopeConfig->isSetFlag(
             self::XML_PATH_DISPLAY_PRODUCT_STOCK_STATUS,
-            \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
+            ScopeInterface::SCOPE_STORE,
             $store
         );
     }
 
     /**
+     * Get Default Config Value
+     *
      * @param string $field
      * @param null|string|bool|int|\Magento\Store\Model\Store $store
      * @return string|null
@@ -385,20 +405,22 @@ public function getDefaultConfigValue($field, $store = null)
     {
         return $this->scopeConfig->getValue(
             self::XML_PATH_ITEM . $field,
-            \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
+            ScopeInterface::SCOPE_STORE,
             $store
         );
     }
 
     /**
+     * Get Stock Threshold Qty
+     *
      * @param null|string|bool|int|\Magento\Store\Model\Store $store
      * @return string|null
      */
     public function getStockThresholdQty($store = null)
     {
         return $this->scopeConfig->getValue(
             self::XML_PATH_STOCK_THRESHOLD_QTY,
-            \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
+            ScopeInterface::SCOPE_STORE,
             $store
         );
     }

app/code/Magento/CatalogInventory/Test/Unit/Model/ConfigurationTest.php

@@ -144,7 +144,7 @@ public function testGetEnableQtyIncrements()
         $store = 1;
 
         $this->scopeConfigMock->expects($this->once())
-            ->method('getValue')
+            ->method('isSetFlag')
             ->with(
                 Configuration::XML_PATH_ENABLE_QTY_INCREMENTS,
                 \Magento\Store\Model\ScopeInterface::SCOPE_STORE,