Fix type hint of @message declaration as the "setWidgetParameters" method allows arrays too #18155
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The magic
setWidgetParameters
method of the\Magento\Widget\Model\Widget\Instance
class accepts not only strings as its parameter, but also arrays. If it's an array, it gets transformed to a string automatically before saving. This PR adds the corresponding type hint.Fixed Issues (if relevant)
The IDE shows a warning if you use an array as a parameter:
This is especially annoying as the
getWidgetParameters
returns an array. It should be possible to use the same data type for getter and setter of one field.Manual testing scenarios
Insert the following code into your IDE:
It shouldn't show a warning as displayed in the screenshot above.
Contribution checklist