Skip to content

Conversation

hostep
Copy link
Contributor

@hostep hostep commented Sep 23, 2018

…ells) show up in the backend grids and in the correct order. Fixes #13720

(cherry picked from commit a3f1c38)

Description

As requested in #17885 (comment), this is a forward port of #17885 for the 2.3 release line.
See original PR for full description.

Fixed Issues (if relevant)

  1. Only 2 related products are showing in backend . #13720: Only 2 related products are showing in backend
  2. Import related products issue #14050: Import related products issue

Manual testing scenarios

  1. Have a product with 5 to 10 related products
  2. Go into the database and look at the table catalog_product_link_attribute_int
  3. All positions (value column, for product_link_attribute_id == 1) should be unique if you created those related products through the backend
  4. To simulate a product import where the positions can end up being non-unique, run the following query: UPDATE catalog_product_link_attribute_int SET value = 1 WHERE product_link_attribute_id = 1;
  5. Take a look at the product in the adminhtml and open the Related Products, Up-Sells, and Cross-Sells section.
  6. Without this fix, you'll only see 2 products, not the full list, with this fix all products show up in the correct sort order.
  7. Also check the frontend, before and after the fix, the sort order will be the same over there, so frontend sort order isn't affected by this change.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

…ells) show up in the backend grids and in the correct order. Fixes magento#13720

(cherry picked from commit a3f1c38)
@magento-engcom-team
Copy link
Contributor

Hi @hostep. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-3035 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @hostep. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only 2 related products are showing in backend .
3 participants