-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing a dedicated cron.log file for logging cron related info, … #18209
Introducing a dedicated cron.log file for logging cron related info, … #18209
Conversation
…this reduces output in the system.log file.
Hi @hostep. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
@magento-engcom-team give me test instance |
Hi @VladimirZaets. Thank you for your request. I'm working on Magento instance for you |
Hi @VladimirZaets, here is your new Magento instance. |
Hi @slavvka, thank you for the review. |
Hi @hostep. Thank you for your contribution. |
Hi @hostep, we need the fix to be delivered also to 2.2-develop branch so please don't forget to port this PR to 2.2-develop; you can do it easily using the Porting Tool, https://devdocs.magento.com/guides/v2.2/contributor-guide/contributing.html#porting-tool |
…this reduces output in the system.log file.
Description
Magento 2.2.5 introduced better handling of cron job locking, but also added some extra logging output. This happened in f274f03 (file:
app/code/Magento/Cron/Observer/ProcessCronQueueObserver.php
).For example, following extra output is logged now:
Cron Job sales_send_order_emails is run
Cron Job sales_send_order_emails is successfully finished. Statistics: {"sum":0.00037288665771484,"count":1,"realmem":0,"emalloc":752,"realmem_start":39845888,"emalloc_start":36019592}
But all this gets logged in the
system.log
file, and it happens for every cron job. Some of them run every single minute, so this causes a lot of extra output in thesystem.log
file, which makes it harder to find other non-cron related output in that file.This PR introduces a new file
cron.log
where all cron related output gets logged.Fixed Issues (if relevant)
Manual testing scenarios
bin/magento cron:run
system.log
, but now in a dedicatedcron.log
fileContribution checklist