Module Catalog: fix issue with custom option price conversion for different base currency on website level

[oleksii-lisovyi]

Description

Issue is connected to the custom option price conversion based on base currency configured on default level, but not on website level (Magento allows to configure different base currency on website level according to documentation).

It's reproduced on the following Magento setup with multi-currency configuration:

1. There are 2 websites configured: US and CA (or another one).
2. Base Currency is configured in the next way: default level - USD; CA - CAD.
3. And if you try to update product with custom options (with non zero price) on CA website level, for example, you need just to change product price, every time you save the product, custom options price will be converted according to USD/CAD currency rate.

Fixed Issues (if relevant)

No related issues found.

Manual testing scenarios

Steps to reproduce

1. Create 2 websites on Magento: US website and CA website.
2. Set up Base Currency to USD (or any other) on default scope.
3. Set up Base Currency to CAD on CA website scope.
4. Create product with custom options and set up non zero price for option value.
5. Save the product.
6. Change configuration scope on CA website.
7. Save product.

Expected result
Custom option value price is not changed, because no actual changes were done.

Actual result
Custom option value price is updated according to USD/CAD currency rate.

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-cicd2]

All committers have signed the CLA.

[magento-engcom-team]

Hi @oleksii-lisovyi. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[magento-engcom-team]

Hi @slavvka, thank you for the review.
ENGCOM-3038 has been created to process this Pull Request

[magento-engcom-team]

@oleksii-lisovyi thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[slavvka]

@oleksii-lisovyi could please also up-port the fix to 2.3 (once it is reproduced there)? You could look the guide here https://devdocs.magento.com/guides/v2.2/contributor-guide/contributing.html#porting

[oleksii-lisovyi]

@slavvka, sure. I tried to make it with PR Porting Tool, but I'm getting an error "Sorry, you can't create port for not merged pull request.". Should I prepare up-port manually instead of using the tool?

[ihor-sviziev]

@oleksii-lisovyi no, no need to create it manually

[magento-engcom-team]

Hi @oleksii-lisovyi. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

[oleksii-lisovyi]

@slavvka, up-port PR has been created.

[slavvka]

@oleksii-lisovyi thank you!