-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CategoryProcessor.php #18271
Update CategoryProcessor.php #18271
Conversation
Hi @ulftietze. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Can somebody tell me why this test fails? :D |
Hi @ulftietze. The test is failing due to newly introduced PHP DocBlock Validator. Since the test is run only against changed files and you changed the file, it is failing. You could fix the issue if you please or wait until we decide how to deal with such cases. |
Hey @slavvka,+ thanks for your reply. Can i something to fix this issue or failing test? Thanks and greetz, |
Hey @ulftietze. I would appreciate if you did that. You could refer to the guide https://devdocs.magento.com/guides/v2.2/coding-standards/docblock-standard-general.html |
Hi @slavvka, thank you for the review. |
@ulftietze thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
Hey @slavvka, thanks for fixing this :D i had recently no time for this :/ |
@ulftietze no problem :) |
Hi @ulftietze. Thank you for your contribution. |
Description
This fix make it possible, that the upsert category process during product import are generating the freshly created category url rewrites globally and not just for the default scope
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist