Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required fields to templates #18343

Merged
merged 3 commits into from
Oct 12, 2018

Conversation

miguelbalparda
Copy link
Contributor

Description

Developers submit PRs and issues without the template. This PR adds required fields.

Fixed Issues (if relevant)

  1. Not relevant

Manual testing scenarios

  1. Create a PR or issue
  2. New text reads "Fields marked with (*) are required. Please don't remove the template."

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@miguelbalparda miguelbalparda changed the title Templates Add required fields to templates Oct 2, 2018
@ihor-sviziev
Copy link
Contributor

@sidolov will it be correctly validated by engcom bot?

@rogyar rogyar self-assigned this Oct 4, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Oct 4, 2018
@magento-engcom-team
Copy link
Contributor

@miguelbalparda thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@sidolov
Copy link
Contributor

sidolov commented Oct 4, 2018

@ihor-sviziev it should work correctly with such changes, but we need to verify after the PR will be merged.

@magento-engcom-team magento-engcom-team merged commit 921333c into magento:2.3-develop Oct 12, 2018
@magento-engcom-team
Copy link
Contributor

Hi @miguelbalparda. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants