Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 2.2 - Allow keyboard navigation in browser on product detail… #18391

Conversation

hostep
Copy link
Contributor

@hostep hostep commented Oct 4, 2018

… pages, by fixing fotorama library to not change to a different image when pressing left or right arrow key in combination with certain modifier keys on your keyboard.

(cherry picked from commit d134a23)

Description

This is a backport of #18212 for Magento 2.2, see original PR for full description.

Watch out, the minfied file is slightly different then in the 2.3 branch, it uses eG.keyCode instead of e.keyCode, be sure to review with care. I tested with minified JS enabled in production mode, to be sure it works fine and it does.

Fixed Issues (if relevant)

None that I could find.

Manual testing scenarios

See original PR

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

… pages, by fixing fotorama library to not change to a different image when pressing left or right arrow key in combination with certain modifier keys on your keyboard.

(cherry picked from commit d134a23)
@magento-engcom-team
Copy link
Contributor

Hi @hostep. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants