Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #12969 - server port detection for errors #18393

Merged
merged 3 commits into from
Oct 16, 2018
Merged

Fix for #12969 - server port detection for errors #18393

merged 3 commits into from
Oct 16, 2018

Conversation

lstellway
Copy link

@lstellway lstellway commented Oct 4, 2018

Description

Updates getHostUrl() method to reference HTTP_HOST rather than SERVER_PORT.

Fixed Issues

  1. magento/magento2#12969 - processor.php getHostUrl() does not detect the server port correctly

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Updates `getHostUrl()` method to reference `HTTP_HOST` rather than `SERVER_PORT`.
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Oct 4, 2018

CLA assistant check
All committers have signed the CLA.

@josefbehr
Copy link
Contributor

@loganstellway Thank you for your contribution. Can you please fix the failing static tests?

FILE: /home/travis/build/magento/magento2/pub/errors/processor.php

FOUND 2 ERRORS AFFECTING 2 LINES

382 | ERROR | [x] Missing short description
383 | ERROR | [x] There must be exactly one blank line before tags

@magento-engcom-team
Copy link
Contributor

Hi @josefbehr, thank you for the review.
ENGCOM-3160 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@loganstellway thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team
Copy link
Contributor

Hi @loganstellway. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants