Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FORWARDPORT] [FEATURE] [issue-3283] Added Filter Support for Yes/No #18434

Conversation

lewisvoncken
Copy link
Contributor

@lewisvoncken lewisvoncken commented Oct 6, 2018

…ibutes

Description

Forwardport of PR #17823

Currently it is only possible to set an attribute to is_filterable to attributes with catalog input type Dropdown, Multiple Select and Price. But in some cases you want a Yes/No (boolean) attribute to be filterable.

Fixed Issues (if relevant)

  1. «Yes/No» attributes should be allowed in the Layered Navigation #3283: «Yes/No» attributes should be allowed in the Layered Navigation

Manual testing scenarios

Before:
1.
image

image

After:
1.
image
2.
image
3. After a reindex the attribute will be displayed as a filter!

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@lewisvoncken
Copy link
Contributor Author

#SQUASHTOBERFEST

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-3129 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @lewisvoncken. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants