Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Typo in Data\Form\Element\Factory.php #18476

Merged
merged 1 commit into from
Oct 16, 2018
Merged

Fix Typo in Data\Form\Element\Factory.php #18476

merged 1 commit into from
Oct 16, 2018

Conversation

zack6849
Copy link
Contributor

@zack6849 zack6849 commented Oct 8, 2018

Sorry for the small PR!

Fixes typo in \Magento\Framework\Data\Form\Element\Factory.php

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Oct 8, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@VladimirZaets VladimirZaets self-assigned this Oct 9, 2018
@VladimirZaets
Copy link
Contributor

Hi @zack6849 , please, sign CLA, otherwise, we can't process your pull request

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Oct 11, 2018
@magento-engcom-team
Copy link
Contributor

@zack6849 thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team magento-engcom-team merged commit 80f19c1 into magento:2.3-develop Oct 16, 2018
magento-engcom-team pushed a commit that referenced this pull request Oct 16, 2018
ENGCOM-3155: Fix Typo in Data\Form\Element\Factory.php #18476
55fe7c6
@magento-engcom-team
Copy link
Contributor

Hi @zack6849. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@zack6849 zack6849 deleted the patch-1 branch October 16, 2018 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@VladimirZaets VladimirZaets

@sidolov sidolov

Labels
Cleanup Component: Framework/Data Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.1
Development

Successfully merging this pull request may close these issues.
6 participants
@zack6849 @magento-cicd2 @VladimirZaets @magento-engcom-team @ihor-sviziev @sidolov