Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added validation on maximum quantity allowed in shopping cart #18481

Merged

Conversation

gelanivishal
Copy link
Contributor

Description

Fixed validation maximum allowed quantity in cart,

Fixed Issues (if relevant)

  1. Set maximum Qty Allowed in Shopping Cart is 0 still allow adding to cart #18477: Set maximum Qty Allowed in Shopping Cart is 0 still allow adding to cart

Manual testing scenarios

  1. Click to edit simple product, then click "Advanced Inventory ", enter 0 in "maximum Qty Allowed in Shopping Cart" field
  2. Don't allow to add 0 in input box

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@rogyar
Copy link
Contributor

rogyar commented Oct 9, 2018

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, here is your Magento instance.
Admin access: https://i-18481-2-3-develop.engcom.dev.magento.com/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@rogyar
Copy link
Contributor

rogyar commented Oct 9, 2018

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants