[Backport] Empty option Label should always be blank even if attribute is required #18564
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#18221
Description
When adding an empty option, Magento checks if the attribute is required or not. If it's not required, it adds an empty option with a space label (
), but if it's required it adds an empty option without label.
The issue is when an attribute is required, the empty option is not selected by default, it's the first option. It causes some issues because if the admin does not pay attention, he/she will save the product with the first option. That's not what is expected, we want an error message telling this attribute is required.
Manual testing scenarios
Before this PR
Option 1
,Option 2
,Option 3
Option 1
as value for this attributeAfter this PR
Option 1
,Option 2
,Option 3
Contribution checklist