-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Forwardport] Fix Customer custom attributes lost after save #18571
[Forwardport] Fix Customer custom attributes lost after save #18571
Conversation
Hi @gelanivishal. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hi @sidolov, thank you for the review. |
Hi @gelanivishal. Thank you for your contribution. |
1 similar comment
Hi @gelanivishal. Thank you for your contribution. |
Original Pull Request
#17968
Description
The customer model has an attribute
attribute_set_id
that links to its attribute set. It is used while saving, as there is a check to see if its attributes are in the set or not, using this link.We want to avoid a
null
attribute_set_id
.Fixed Issues
Manual testing scenarios
No regression manual test:
6. Programmatically load the customer, add a different not-yet-defined attribute to customer (e.g.
setNotYetDefined(1)
) and save directly using the model.7. Reload the customer: the custom value is still not lost, while
not_yet_defined
is lost.Contribution checklist