18615 updates structure for last_trans_id to be varchar 255 which is …

[iancassidyweb]

Description (*)

• Resolves 18615
• Klarna orders are not being stored correctly in 'sales_order_payment'.'last_trans_id' due to the structure of the field having a limit of 32 characters where as the klarna reference is currently 36 characters.
• The structure for last_trans_id has been updated from Varchar 32 to Varchar 255
• This is inline with the structures for:
  • klarna_core_order order_id
  • amazon_sales_order amazon_order_reference_id
• This should provide greater compatibility with 3rd party payments.

Fixed Issues (if relevant)

1. Field restriction incompatibilities between klarna_core_order and sales_order_payment last_trans_id #18615: Field restriction incompatibilities between klarna_core_order and sales_order_payment last_trans_id

Manual testing scenarios (*)

1. Configure klarna payment gateway in sandbox mode https://playground.eu.portal.klarna.com
2. Place test order using Klarna
3. Observe the 'sales_order_payment'.'last_trans_id' and record reference
4. Compare this reference with the value stored in 'klarna_core_order'.'klarna_order_id'
5. Configure amazon payment gateway in sandbox mode
6. Place test order using Amazon
7. Observe the 'sales_order_payment'.'last_trans_id' and record reference
8. Compare this reference with the value stored in 'amzon_sales_order'.'amazon_order_reference_id'

Contribution checklist (*)

• [ x] Pull request has a meaningful description of its purpose
• [ x] All commits are accompanied by meaningful commit messages
• [ x] All new or changed code is covered with unit/integration tests (if applicable)
• [ x] All automated tests passed successfully (all builds on Travis CI are green)

[magento-cicd2]

All committers have signed the CLA.

[magento-engcom-team]

Hi @iancassidyweb. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[miguelbalparda]

This should go in an upgrade script with a version bump. Leaving this change here will only make it work for new installs and won't be reflected if anyone already installed M2 and is upgrading.

[iancassidyweb]

Sure. will update at weekend.

[iancassidyweb]

@miguelbalparda I got the following error from Codacy

"Codacy/PR Quality Review — Codacy was unable to analyse your pull request."

Let me know if you need anything else.

Ian

[miguelbalparda]

Codacy seems to be disabled for 2.2. I'll check this internally, thanks for the heads up!

[magento-engcom-team]

Hi @miguelbalparda, thank you for the review.
ENGCOM-3494 has been created to process this Pull Request

[magento-engcom-team]

Hi @iancassidyweb. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.